Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/assets/i18n: CrossRef → Crossref #3029

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

alanorth
Copy link
Contributor

Description

As part of a rebranding in 2015 Crossref started stylizing their name as "Crossref" instead of "CrossRef".

See: https://www.crossref.org/blog/the-logo-has-landed/

Instructions for Reviewers

List of changes in this PR:

  • Rename "CrossRef" in i18n strings

Include guidance for how to test or review your PR.

  • Make sure "Crossref" is displayed in the user interface instead of "CrossRef" (for example, on the MyDSpace import from external sources page)

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@alanorth alanorth added i18n / l10n Internationalisation and localisation, related to message catalogs low priority labels May 10, 2024
@tdonohue tdonohue added 1 APPROVAL pull request only requires a single approval to merge port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels May 10, 2024
Copy link

github-actions bot commented Jun 7, 2024

Hi @alanorth,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

As part of a rebranding in 2015 Crossref started stylizing their
name as "Crossref" instead of "CrossRef".

See: https://www.crossref.org/blog/the-logo-has-landed/
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @alanorth ! Gave this a look/test today. It all looks good & I'll try to backport it to 7.x

@tdonohue tdonohue added this to the 8.0 milestone Jun 18, 2024
@tdonohue tdonohue merged commit ca61647 into DSpace:main Jun 18, 2024
13 checks passed
@dspace-bot
Copy link
Contributor

Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-7_x
git worktree add -d .worktree/backport-3029-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-3029-to-dspace-7_x
git switch --create backport-3029-to-dspace-7_x
git cherry-pick -x ae221df3a444bb59ac044cf79ed8cd6a7698761f

@tdonohue
Copy link
Member

Ported to 7.x in #3135

@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label Jun 18, 2024
@alanorth alanorth deleted the i18n-crossref-case branch June 20, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs low priority
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants